Display a different color for installed components during a toolchain install#4875
Display a different color for installed components during a toolchain install#4875FranciscoTGouveia wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
The :.green.bold and the actual test is too far away from each other so I'm not sure if I'd like this change... To me intuitively the prefix should have been the name of the component:
That said I'm not an indicatif expert either, but if there's a more straightforward way I'd choose that.
|
Can you add before and after screenshots in the PR description? |
FranciscoTGouveia
force-pushed
the
component-installed-color
branch
from
4a4c8a4 to
3f5db61
Compare
|
I have already updated the PR description with the screenshots.
From what I can tell, What are your thoughts about this? |
There was a problem hiding this comment.
From what I can tell,
indicatifcan only color placeholder fields, not literal text. The only alternative I can see is to set the the component name as the{prefix}and then set the"installed"as{msg}.
@FranciscoTGouveia OK with me then! Thanks :)
3 participants
Closes #4870.
I decided to set a prefix for the
ProgressBarsince we were not using one before.Looking at indicatif's documentation, this seemed like a reasonable way to style a specific portion of the
ProgressBar.Is there a more idiomatic approach to achieving this that I might be overlooking?
CC @djc
I have left two screenshots below to illustrate this change.
Before:
After:
NB: My terminal does not display the last message (regarding the installed toolchain) in bright green as it should.